Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] CSSUnparsedValue constructor behaviour if arguments are not alternating #495

Closed
darrnshn opened this issue Oct 23, 2017 · 2 comments

Comments

@darrnshn
Copy link
Collaborator

In the wording for the tokens internal slot of CSSUnparsedValue, it says that tokens is "a list of alternating DOMString and CSSVariableReferenceValue objects". What happens if a CSSUnparsedValue was created with non-alternating tokens? e.g.

new CSSUnparsedValue('foo', 'bar');
@tabatkins
Copy link
Member

That statement is just wrong in the first place - I think --foo:var(bar)var(baz); would have two variables references in a row, without a string in the middle. (Theoretically we could put an empty string there, but why?) I should remove it.

@shans
Copy link
Contributor

shans commented Nov 2, 2017

I don't think I ever intended it to mean strictly alternating. The sense was that you could alternate back and forth between the two types in a single list (as opposed to either having a list of one or a list of the other).

We definitely should reword to make this less confusing, but I think it'd be good to retain that sense somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants