Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-typed-om] "delete a StylePropertyMap" algorithm is poorly named #570

Closed
dbaron opened this issue Jan 26, 2018 · 2 comments
Closed

[css-typed-om] "delete a StylePropertyMap" algorithm is poorly named #570

dbaron opened this issue Jan 26, 2018 · 2 comments
Labels
Commenter Satisfied css-typed-om-1

Comments

@dbaron
Copy link
Member

dbaron commented Jan 26, 2018

The spec defines a delete a StylePropertyMap algorithm. But this is really about deleting a property from a StylePropertyMap. Perhaps it should be called "delete from a StylePropertyMap"?
@darrnshn
Copy link
Collaborator

Yes, that should be "delete a value from StylePropertyMap" (consistent with "set a value" and "get a value").

@darrnshn darrnshn mentioned this issue Jan 28, 2018
Closed
@darrnshn
Copy link
Collaborator

Fixed in #583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Commenter Satisfied css-typed-om-1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbaron @darrnshn