Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] definition of CSSMathValue.equals() should be a little clearer #576

Closed
dbaron opened this issue Jan 28, 2018 · 0 comments
Closed

Comments

@dbaron
Copy link
Member

dbaron commented Jan 28, 2018

The definition of CSSMathValue.equals() seems to lack a bit of formality in the final step. In particular, the final step currently begins with:

If all items in thisAndValues are of type CSSMathValue:

and then has two options that require iterating over a bunch of values.

The text doesn't actually say how to take this iteration and produce a single result (true or false) from the equals function. It probably should.

It also feels like the wording could be clearer in other ways, e.g., in terms of describing what exactly is being iterated over and how many recursive calls to the algorithm are made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants