Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] specify CSSMatrixComponentOptions default with IDL defaults? #612

Closed
dbaron opened this issue Jan 30, 2018 · 1 comment
Closed

Comments

@dbaron
Copy link
Member

dbaron commented Jan 30, 2018

The CSSMatrixComponent constructor spec says:

If options was passed and has a CSSMatrixComponentOptions field, set this’s is2D internal slot to the value of that field.

One problem with this is that CSSMatrixComponentOptions probably meant to say is2D.

However, it seems like the normal way to specify these things is using WebIDL dictionary defaults. Maybe that's better, and it could avoid needing to write the part of this sentence with the mistake?

@tabatkins
Copy link
Member

Closing the loop since #692 reverts #613 and ends up closing this issue as invalid...

No, the lack of a default is intentional. Specifying one way or the other is an active choice with consequences; our current lack of default lets us at least infer what you might want from the passed matrix. The only other reasonable option would be to make it required, but that doesn't seem necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants