Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-typed-om] Constructor for CSSUnparsedValue takes rest params rather than sequence #618

Closed
TimothyGu opened this issue Jan 31, 2018 · 1 comment
Closed

[css-typed-om] Constructor for CSSUnparsedValue takes rest params rather than sequence #618

TimothyGu opened this issue Jan 31, 2018 · 1 comment
Labels
css-typed-om-1

Comments

@TimothyGu
Copy link
Member

The constructor for CSSUnparsedValue takes (DOMString or CSSVariableReferenceValue)... rest parameters. This is inconsistent with pretty much every collection-style constructor in ES and the Web Platform, including:

which take a sequence<> (or equivalent) as the sole parameter.

From IRC #whatwg:

@TimothyGu | @tabatkins: question: why did y'all decide on rest params for CSSUnparsedValue's constructor instead of a sequence<>?
@tabatkins | I think we didn't have any particular reason, but since it's inconsistent with CSSTransformValue we should harmonize those two.
@TimothyGu TimothyGu changed the title [css-typed-om] [css-typed-om] Constructor for CSSUnparsedValue takes rest params rather than sequence Jan 31, 2018
@nainar nainar mentioned this issue Jan 31, 2018
Merged
@TimothyGu
Copy link
Member Author

That was fast. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-typed-om-1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimothyGu @nainar