Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-view-transitions-2] Should CSSViewTransitionTypeSet specifically handle none? #10142

Closed
cdoublev opened this issue Mar 26, 2024 · 1 comment
Closed

[css-view-transitions-2] Should CSSViewTransitionTypeSet specifically handle none? #10142

cdoublev opened this issue Mar 26, 2024 · 1 comment
Labels
Closed Rejected as Invalid css-view-transitions-2 View Transitions; New feature requests

Comments

@cdoublev
Copy link
Collaborator

Since @view-transition/types is defined with either none or <custom-ident>+, should CSSViewTransitionTypeSet entries be cleared when adding none?

Note: there is probably no need to check for a valid <custom-ident>, assuming the input is escaped at parse/serialization time when required (eg. {}, ;, 1, etc).
@cdoublev cdoublev added the css-view-transitions-2 View Transitions; New feature requests label Mar 26, 2024
@cdoublev
Copy link
Collaborator Author

The set is readonly. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Rejected as Invalid css-view-transitions-2 View Transitions; New feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cdoublev