Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-properties-values-api] Are fallbacks provided for registered properties validated by the CP syntax? #10455

Open
LeaVerou opened this issue Jun 17, 2024 · 2 comments

Comments

@LeaVerou
Copy link
Member

Take a look at this codepen, which is surprisingly interoperable across UAs: https://codepen.io/leaverou/pen/oNRpEGO

--color is defined as:

@property --color {
	syntax: "lime | yellowgreen";
	initial-value: yellowgreen;
	inherits: false;
}
Actual Expected
image image

Given that…

  1. Registered properties become IACVT when they are given a value that does not parse with their defined syntax,
  2. IACVT properties behave as if their value is unset and properties that do not inherit handle unset as intiial
  3. --color’s initial value is yellowgreen
  4. --color is defined to not inherit

…I would have expected yellowgreen, not transparent. It is especially weird that this only happens when a fallback value is provided that does not match the property syntax.

Given the behavior is interoperable, @kizu assumed there must be a WPT test about this, but could not find a test that would test this interaction. The only place he found that tests the fallback not applying when the variable uses its fallback value is here: https://github.com/web-platform-tests/wpt/blob/master/css/css-pseudo/highlight-cascade/highlight-cascade-003.html#L8-L14
But there is no test (or we can't find it) that covers this weird behavior.

I guess, if anything describes what should happen, then it is https://drafts.csswg.org/css-variables/#invalid-variables

Either the property’s inherited value or its initial value depending on whether the property is inherited or not, respectively, as if the property’s value had been specified as the unset keyword.

However, that is not what is happening in the second test. Changing whether the property inherits and setting --color: lime on the parent does not change the outcome of the second test, only the others: https://codepen.io/leaverou/pen/oNRpEGO

It should be clarified in the specs whether the value of the fallback used in the var() should also be validated by the custom property syntax or treated as an unregistered token stream that is validated at the point of usage (I would vote for the latter, but no strong opinion) and what the behavior is in that case.

Also tagging as Agenda+ since @property usage is going to pick up soon now that Firefox has implemented, and authors are soon going to start hitting this.

Thanks to @kizu for his help in tracking this down

@Loirooriol
Copy link
Contributor

gold is provided as a fallback in a declaration for background, not for --color, so validating it against the grammar of --color seems very unexpected to me.

@tabatkins
Copy link
Member

Yeah, fallback in var() should be completely unrelated to whatever conditions are imposed on the custom property referenced by the var(). Nothing in any of the specs suggests there should be such an effect; the behavior of the fallback is indeed just "an unregistered token stream that is validated at the point of usage".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants