Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-tables][css-ruby] Fixup should create inline-table when parent inlinifies #1590

Closed
Loirooriol opened this issue Jul 10, 2017 · 1 comment
Assignees
Labels
css-ruby-1 Current Work css-tables-3 Current Work

Comments

@Loirooriol
Copy link
Contributor

The fix-up algorithm only creates an anonymous inline-table when the parent box is an inline box.

However, this should also happen whenever the parent inlinifies its contents. It's worth noting that, according to CSS Display, inlinification happens before anonymous fix-up, so the fix-up algorithm can't rely on inlinification to make table become inline-table.

Currently I think inlinification only happens in ruby containers, and run-in boxes with a flow inner display type. Gecko is the only proper implementation of ruby, and effectively it seems to generate an anonymous inline-table inside a ruby container. I don't know any implementation of run-ins, but a run-in with a flow inner display type seems to be considered an inline box (this should be clarified in #1491); so this case may already be covered by the current spec.

@tabatkins tabatkins added the css-display-3 Current Work label Jul 11, 2017
@fantasai fantasai added css-tables-3 Current Work css-ruby-1 Current Work and removed css-display-3 Current Work labels Jul 11, 2017
@fantasai
Copy link
Collaborator

This is a different process than inlinification, which is a computed-time operation. Refiling against CSS Tables: they just need to say that an inline-table is generated inside ruby bases / annotations, just like it is inside regular inline boxes. (As you note, handling within run-ins is clarified in #1491.)

@fantasai fantasai changed the title [css-tables][css-display] Fixup should create inline-table when parent inlinifies [css-tables][css-ruby] Fixup should create inline-table when parent inlinifies Jul 11, 2017
@FremyCompany FremyCompany added this to Ready for edits in css-tables-3 Jul 12, 2017
@FremyCompany FremyCompany self-assigned this Jul 19, 2017
@FremyCompany FremyCompany moved this from Ready for edits to DOC in css-tables-3 Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-ruby-1 Current Work css-tables-3 Current Work
Projects
Development

No branches or pull requests

4 participants