Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-multicol] Something went wrong with the linking or code block? #1850

Closed
praveenpuglia opened this issue Oct 5, 2017 · 4 comments
Closed
Assignees
Labels
css-multicol-1 Current Work

Comments

@praveenpuglia
Copy link
Contributor

Here - https://www.w3.org/TR/2017/WD-css-multicol-1-20171005/#example-3694c0ea
& the example after that.

image

@bert-github
Copy link
Contributor

Somehow the word "or" got marked-up as a code example, instead of the two declarations on either side. Nothing serious, all the text is still there, but it doesn't quite look as it should.

Also, the quote marks in the example aren't wrong, but a bit redundant, typographically speaking. When the code is already set on a line of its own, the quotes aren't really needed. And when the code ends with a newline, you get a closing quote at the start of the line, which looks unusual. That newline is not actually needed, we can remove it. But, given that the quotes are added by the style sheet, we probably need a slightly smarter style sheet anyway.

@rachelandrew
Copy link
Contributor

I've updated the editor's draft to use highlight="css" instead of class="css" in order that these will use the Pygments syntax highlighting.

I'm updating the examples anyway to use clearer images, so I'll make sure all these chunks of code are properly highlighted at the same time. Thanks for the report.

@rachelandrew rachelandrew added the css-multicol-1 Current Work label Oct 6, 2017
@rachelandrew rachelandrew self-assigned this Oct 6, 2017
@tabatkins
Copy link
Member

Heh, there are two separate markup bugs in this screenshot.

The first is that Bikeshed doesn't track autolink shortcuts across linebreaks (being conservative for safety), and in the source file there's a linebreak in the middle of the "position: fixed" text. So its starting '' isn't recognized, its ending '' is instead interpreted as the start of a css autolink covering the "or", and the '' at the end of "position: absolute" isn't recognized. I just fixed this.

The second is that class=css is used to style things as css snippets, which are surrounded by single quotes. Putting it on a pre has some unfortunate implications. Better is to use either class=lang-css or highlight=css to indicate that it's CSS code that needs highlighting. Thanks for doing that already, @rachelandrew.

Since both issues are now fixed, I'll close this issue. Thanks for the report, @praveenpuglia!

@praveenpuglia
Copy link
Contributor Author

Glad I could help! :)

@rachelandrew rachelandrew added this to Done in css-multicol-1 Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-multicol-1 Current Work
Projects
Development

No branches or pull requests

4 participants