Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-animations-1] getKeyframes() processing steps need updating after null composite #2289

Closed
graouts opened this issue Feb 8, 2018 · 2 comments

Comments

@graouts
Copy link
Contributor

graouts commented Feb 8, 2018

In KeyframeEffectReadOnly::getKeyframes(), we now say that composite should always be set with a default of null in the non-normative section:

composite
The keyframe-specific composite operation used to combine the values specified in this keyframe with the underlying value.

This member will be null if the composite operation specified on the keyframe effect is being used.

However, in the (normative) processing steps below, we say:

  1. Set offset, computedOffset, easing members of output keyframe to the respective values keyframe offset, computed keyframe offset, and keyframe-specific timing function of keyframe.

  2. If keyframe has a keyframe-specific composite operation, set composite to that value.

I believe we should get rid of 3. and update 2. to read:

  1. Set offset, computedOffset, easing, composite members of output keyframe to the respective values keyframe offset, computed keyframe offset, keyframe-specific timing function and keyframe-specific composite operation of keyframe.
@birtles
Copy link
Contributor

birtles commented Feb 16, 2018

Yeah, this is one of the (many) awkwardnesses of having a separate model and API. The intention was that "null" is just an API concept corresponding to the absence of a keyframe-specific composite operation. However, we already talk about null offset values so we should just talk about null composite operations too.

@birtles
Copy link
Contributor

birtles commented Feb 16, 2018

2625ca2 fixes the obvious grammatical error in that previous commit too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants