Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review old CSS2 edits #2554

Open
gsnedders opened this issue Apr 12, 2018 · 2 comments
Open

Review old CSS2 edits #2554

gsnedders opened this issue Apr 12, 2018 · 2 comments
Labels

Comments

@gsnedders
Copy link
Contributor

gsnedders commented Apr 12, 2018

non-HTML edits (source files, etc.)

html file edits (not source files)

Some of these look like edits by other people that should also be made

  • a542587 explicitly specify what gets set to what with MCW
  • c048c41 [CSS2] Regenerated.
  • 2614704 [CSS2] Regenerated.
  • fca2290 [CSS2] Overview.html was apparently not yet under version control
  • 39dae95 [css2-testing] Regenerated
  • 7da6f06 [CSS23] (Regenerated)
  • 6ad65cb [CSS22] Regenerated
  • 5c9731c [CSS21] Regenerated
  • b739b88 [CSS21] Generated.
  • 13731f3 Generated. Do not edit!
  • 54c41bc Generated. Do not edit!
  • 6cd1606 Generated. Do not edit!
  • 1aae4a7 Generated. Do not edit!
  • 64cefa3 [CSS22] regenerated
  • e43adf5 [CSS22] regenerated
  • ee65ccb Generated. Do not edit!
  • 140726f [css2] css2.html is an intermediate file in the make process and should not be version-controled
  • 122d5b2 Generated. Do not edit!
  • 200ebbc Generated. Do not edit!
  • e37022e Generated. Do not edit!
  • f853bbe Generated. Do not edit!
  • 62f4a8f [css2] Generated. Do not edit!
  • 48e4856 [css2] Generated. Do not edit!
  • 9f7bc63 [css2] Generated. Do not edit!
  • a771bb2 [css2] Generated. Do not edit!
  • 4ae8661 [css2] Generated. Do not edit!
  • 9efcc3c [css2] Generated. Do not edit!
  • 507b0a8 [css2] Generated. Do not edit!
  • 8446e10 [css2] Generated. Do not edit!
@gsnedders gsnedders added the CSS2 label Apr 12, 2018
@frivoal
Copy link
Collaborator

frivoal commented Apr 13, 2018

what do the checkboxes represent here? Edits confirmed to be good are supposed to be checked? Are people other than the Editors welcome to check boxes (for example those that correspond to a pull request merged that was merged after a review?)

@gsnedders
Copy link
Contributor Author

@frivoal Dealt with, insofar as they either have an open PR to reland them or we decide we don't want to land them (for whatever reason).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants