Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-logical][quirks] Should logical properties allow the unitless length quirk? #2928

Closed
Loirooriol opened this issue Jul 16, 2018 · 3 comments

Comments

@Loirooriol
Copy link
Contributor

According to https://quirks.spec.whatwg.org/#the-unitless-length-quirk, some properties which accept a <length> must also accept a <quirky-length> in quirks mode.

Various of these properties have corresponding logical properties, which behave more or less like an alias. Should the logical properties accept a <quirky-length> too?

I was assuming that it shouldn't be accepted. However, I noticed that Chromium allows it in these logical properties:

  • scroll-margin-block-end, scroll-margin-block-start, scroll-margin-inline-end, scroll-margin-inline-start
  • scroll-padding-block-end, scroll-padding-block-start, scroll-padding-inline-end, scroll-padding-inline-start

It's not allowed in the other logicals.

I didn't test them all but it seems that Firefox doesn't allow unitless lengths either.

@tabatkins
Copy link
Member

Given the inconsistent support for it in our properties, it seems clear that it's just an accident, not an intentional choice. We should stick with "not allowed", as that quirk doesn't need to be spread any further.

@ewilligers
Copy link
Contributor

Now fixed in Blink, with all browsers passing the WPT. This issue can be closed.

@Loirooriol
Copy link
Contributor Author

OK, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants