Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] Definition of content-sized track #3044

Closed
javifernandez opened this issue Aug 22, 2018 · 2 comments
Closed

[css-grid] Definition of content-sized track #3044

javifernandez opened this issue Aug 22, 2018 · 2 comments
Assignees
Labels
Closed Rejected as Invalid Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-grid-1 Tracked in DoC

Comments

@javifernandez
Copy link
Contributor

The grid spec uses the concept of a content-sized track, but it doesn't define it explicitly. There is a link that points to the CSS Flexible Box spec, which provides the following definition for the content-size term:

https://www.w3.org/TR/css-flexbox-1/#content-size

The content size is the min-content size in the main axis, clamped, if it has an aspect ratio, by any definite min and max cross size properties converted through the aspect ratio, and then further clamped by the max main size property if that is definite.

The link is in the "Significant adjustments and fixes section", so I guess the link inclusion is not intentional and definitively not part of the spec. Hence, I think we should define it properly, either in the grid spec or perhaps in a more general sizing spec (css-sizing ?)

These are a few examples of the use of this term in the grid spec:

https://drafts.csswg.org/css-grid/#grid-auto-flow-property

Example 24 - /* Define three columns, all content-sized,

https://drafts.csswg.org/css-grid/#algo-spanning-items

3- Increase sizes to accommodate spanning items crossing content-sized tracks: Next, ...

For the record, in the Chrome and WebKit implementation we are interpreting a content-sized track as any of the following values:

  • auto
  • min-content
  • max-content

However, I think the fr value is a special case on this regard, or at least, we are assuming that in our implementation. We are assuming that a flex track in a indefinite size container should be considered as a content-sized track; is this assumption valid ? Is there any statement in the grid spec, or any other, specifying that ? If it's not specified, should we include something in the grid spec, at least ?

@tabatkins
Copy link
Member

There's no need to define this term; it's not used in any normative portion of the spec. (It only shows up in the intro, in an example, and previously in the heading to an algorithm section; we've just swapped that to "intrinsically-sized" as it's more correct anyway.)

@javifernandez
Copy link
Contributor Author

ok

@fantasai fantasai added this to the css-grid-1 CR 2017-12-14+ milestone Jan 23, 2019
@fantasai fantasai added Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. Tracked in DoC labels Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Rejected as Invalid Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-grid-1 Tracked in DoC
Projects
None yet
Development

No branches or pull requests

3 participants