Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-syntax] Redundant step in consume url token algo #3054

Closed
Wes0617 opened this issue Aug 25, 2018 · 1 comment
Closed

[css-syntax] Redundant step in consume url token algo #3054

Wes0617 opened this issue Aug 25, 2018 · 1 comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-syntax-3 Testing Unnecessary Memory aid - issue doesn't require tests

Comments

@Wes0617
Copy link
Contributor

Wes0617 commented Aug 25, 2018

I'm not entirely sure, but I think... in section 4.3.6 the step 3:

  1. If the next input code point is EOF, this is a parse error. Return the <url-token>.

Is redundant with the step in the loop (4):

EOF
This is a parse error. Return the <url-token>.

I suggest step (3) to be removed as it's already covered by the loop.

@tabatkins
Copy link
Member

Yes, it's redundant. (It's possible it wasn't previously; I know I've tweaked this section before.)

@tabatkins tabatkins added Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. Testing Unnecessary Memory aid - issue doesn't require tests labels Jan 24, 2019
@tabatkins tabatkins added this to the CSS Syntax 3 June 2019 CR milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-syntax-3 Testing Unnecessary Memory aid - issue doesn't require tests
Projects
None yet
Development

No branches or pull requests

2 participants