Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add top-level shared resources from WPT to test.csswg.org #3076

Closed
gsnedders opened this issue Sep 3, 2018 · 4 comments
Closed

add top-level shared resources from WPT to test.csswg.org #3076

gsnedders opened this issue Sep 3, 2018 · 4 comments
Assignees

Comments

@gsnedders
Copy link
Contributor

See web-platform-tests/wpt#9940 (comment).

@gsnedders
Copy link
Contributor Author

And because I didn't actually mean to hit cmd+return:

I think we should probably just make it possible to use all the top-level shared resource directories (common, fonts, images, media, resources); I think all of these have existed since WPT has, so there's not much risk of new ones getting added.

@plinss said:

If it's just that set of 5 then fine, I can add the others as aliases to the csswg test server. All I had in mind was something like if new shared-resource directories get added that happens under /common (or let's create /shared and put everything, or all new things under that). That way new ones can be added without having to coordinate changes or worry about breakage.

(filing this issue so I have something better to link to than I discussion on a closed PR)

@gsnedders gsnedders changed the title add top-level shared sources from WPT to test.csswg.org add top-level shared resources from WPT to test.csswg.org Sep 3, 2018
@plinss
Copy link
Member

plinss commented Sep 5, 2018

Done

@plinss plinss closed this as completed Sep 5, 2018
@frivoal
Copy link
Collaborator

frivoal commented Sep 5, 2018

@plinss Is there a way to make sure these top level directories are accessible using relative urls?

For instance, if a test is in css/css-foo/test-001.html and a support file is in css/support/bar.png, it would be nice to be able to access it as ../support/bar.png. The motivation is to be able to run tests from file://, which should be sufficient for 99% of css tests that don't actually need a server to make sense. That make writing / reviewing tests much more lightweight.

Is this already possible, or does something need to be tweaked with the build system (or server aliases / redirects)?

@plinss
Copy link
Member

plinss commented Sep 5, 2018

No, because the directory structure gets flattened during the build process. The build does adjust the paths of references, but that's about it. The point of adding these aliases was to allow the use of absolute urls. I thought there was a lightweight python server that could be run locally out of wpt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants