Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-conditional][cssom] Why CSSConditionRule? #3172

Closed
svgeesus opened this issue Sep 27, 2018 · 1 comment
Closed

[css-conditional][cssom] Why CSSConditionRule? #3172

svgeesus opened this issue Sep 27, 2018 · 1 comment

Comments

@svgeesus
Copy link
Contributor

from https://lists.w3.org/Archives/Public/www-style/2013Jun/0331.html by @zcorpan

In http://lists.w3.org/Archives/Public/www-style/2012Aug/0749.html it
was decided to mint the CSSConditionRule interface and have
CSSSupportsRule and CSSMediaRule inherit from it.

I don't understand the usefulness of exposing a new property on
CSSMediaRule that does the same thing as mediaText. Also, conditionText
has different requirements for CSSMediaRule and CSSSupportsRule. Why do
we want to have the same attribute for things that are different?
https://bugzilla.mozilla.org/show_bug.cgi?id=814907#c3 suggests
@-moz-document is again different.

I think it would be better continue with just having .mediaText on
CSSMediaRule, drop the CSSConditionRule interface, and let
CSSSupportsRule and CSSDocumentRule have .conditionText with the
interface-specific requirements.

@zcorpan
Copy link
Member

zcorpan commented Sep 27, 2018

I believe this has been implemented, so I would be ok with closing (but it would be nice to make sure there are tests for this).

@svgeesus svgeesus added Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants