New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox-1] Should the intrinsic sizing algorithm take min-size into account, too? #361

Closed
cbiesinger opened this Issue Jul 29, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@cbiesinger

cbiesinger commented Jul 29, 2016

https://drafts.csswg.org/css-flexbox/#intrinsic-main-sizes

Asks to "then clamp that result by the max main size property.". Why only max and not min?

@fantasai

This comment has been minimized.

Contributor

fantasai commented Feb 16, 2017

I think the reason we left that out was because the size, prior to clamping, is guaranteed to be at least the min-size. However, you're right that we need to floor at the min-size: because clamping by the max-size alone, without consideration of the min-size, could result in violating the min-size.

@fantasai

This comment has been minimized.

Contributor

fantasai commented Feb 16, 2017

@cbiesinger Let me know if that fix looks good to you. :)

@fantasai fantasai added this to the Published css-flexbox-1 2017-10-19 milestone Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment