Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-fonts] Remove font-feature-settings and font-variation-settings descriptors? #4358

Open
svgeesus opened this issue Sep 20, 2019 · 8 comments
Assignees
Labels
css-fonts-4 Current Work

Comments

@svgeesus
Copy link
Contributor

@drott wrote:

At this point we don't implement other descriptors in @font-face, such as font-feature-settings and font-variation-settings - @litherum, do you suggest to keep those and only remove font-variant?

font-variant was removed per WG resolution; this issue is to track whether to also remove font-feature-settings and font-variation-settings descriptors.

There are currently no tests for either, so I plan first to make a couple of WPT tests and then discuss implementer interest in these descriptors.

@litherum
Copy link
Contributor

litherum commented Dec 1, 2021

We support the font-feature-settings descriptor but not the font-variation-settings descriptor.

@LeaVerou
Copy link
Member

LeaVerou commented Dec 1, 2021

Don't we need font-variation-settings for custom axes?

@svgeesus
Copy link
Contributor Author

Webkit and Gecko implement font-feature-settings

@svgeesus
Copy link
Contributor Author

Looks like Chromium, Gecko and WebKit implement font-variation-settings

@svgeesus
Copy link
Contributor Author

Based on the WPT results, suggest closing this issue with no change. There are 2+ implementations in browsers of these descriptors

@svgeesus
Copy link
Contributor Author

(Could do with more tests, but at least we do have tests for both)

@drott
Copy link
Collaborator

drott commented Aug 8, 2022

Based on the WPT results, suggest closing this issue with no change. There are 2+ implementations in browsers of these descriptors

Don't we need to distinguish the function of font-variation-settings as a @font-face descriptor and a style property? IMO that's the core of this issue. Which WPT tests demonstrate that Blink and WebKit respect font-variation-settings as a descriptor? Blink implements font-feature-settings and font-variation-settings as style rules / properties. (I'd have to double check but) I don't think we implement it as a descriptor.

IIUC the intention of the use of font-variation-settings as a descriptor is to set something similar to a "default" value for this font face - so no extra style rule needs to be placed to instantiate the font at a specific coordinate in the variation space.

@svgeesus
Copy link
Contributor Author

svgeesus commented Aug 8, 2022

Don't we need to distinguish the function of font-variation-settings as a @font-face descriptor and a style property? IMO that's the core of this issue.

Ah, indeed. Ignore what I said earlier about WPT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-fonts-4 Current Work
Projects
None yet
Development

No branches or pull requests

4 participants