Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-ui-3] Add an outline-offset to shorthand #441

Closed
yoksel opened this issue Sep 4, 2016 · 2 comments
Closed

[css-ui-3] Add an outline-offset to shorthand #441

yoksel opened this issue Sep 4, 2016 · 2 comments
Assignees
Labels
Closed Rejected as Wontfix by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-ui-3

Comments

@yoksel
Copy link

yoksel commented Sep 4, 2016

Spec: https://www.w3.org/TR/css-ui-3/#propdef-outline

outline doesn't contain outline-offset and it can be added only with a separate line. It would be nice to have outline-offset here too, something like this: outline: 5px/10px solid green

@frivoal frivoal self-assigned this Sep 5, 2016
@frivoal
Copy link
Collaborator

frivoal commented Sep 5, 2016

If we were introducing outline-offset now, I think I would agree with this proposal.

However, both outline and outline-offset have been out for a while now without having a shorthand / longhand relationship. Due to this, the change you're suggestion is likely to be incompatible with existing content.

If outline-offset becomes longhand of outline, then setting outline would always reset outline-offset, even if no outline-offset specific value is provided. For example, the following code would not set the offset to 5px, because the shorthand would win the cascade and reset it to 0.

.highlight {
  outline-offset: 5px;
  outline: 3px solid red;
}

Since this is different from the current behavior, this is almost certain to break existing pages.

Unless you have some evidence or some reason to believe either than this compatibility problem is not occurring, or that even if it does occur it is not actually an issue, I am afraid it is too late to change this.

@yoksel
Copy link
Author

yoksel commented Sep 19, 2016

Thank you for the explanation : ) So simple. I didn't think about it.

@yoksel yoksel closed this as completed Sep 19, 2016
@frivoal frivoal added Closed Rejected as Wontfix by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Rejected as Wontfix by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-ui-3
Projects
None yet
Development

No branches or pull requests

2 participants