Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-contain] Editorial: suggest rephrasing in Introduction #4466

Closed
chrisn opened this issue Oct 29, 2019 · 5 comments
Closed

[css-contain] Editorial: suggest rephrasing in Introduction #4466

chrisn opened this issue Oct 29, 2019 · 5 comments
Assignees
Labels
AC Review Flags (when known as such) comments filed during formal AC reviews. Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-contain-1 css-contain-2 Current Work Tracked in DoC

Comments

@chrisn
Copy link
Member

chrisn commented Oct 29, 2019

I'm doing my W3C AC review of CSS Containment Module Level 1, and have one minor comment about this text in the Introduction:

so innocuous changes to a page may inadvertently make it flunk the heuristics and fall into a slow mode.

I suggested rephrasing, as "flunk" is a region specific colloquialism. It's also not clear what "fall into a slow mode" is referring to (the page itself or the rendering of the page).

I humbly suggest, for example:

so innocuous changes to a page may inadvertently make it fail such heuristic tests, causing rendering to fall into a slow code path.

@frivoal frivoal self-assigned this Oct 29, 2019
@frivoal frivoal added the AC Review Flags (when known as such) comments filed during formal AC reviews. label Oct 29, 2019
@frivoal
Copy link
Collaborator

frivoal commented Oct 29, 2019

Thanks for the feedback. Your suggestion seems reasonable to me.

@astearns @atanassov This would be a completely editorial edit to a non normative section. I'd normally accept that without going through the WG, but we are in Proposed Rec. Should I Agenda+ to get a formal WG resolution, or can I just fix this? Or maybe you can declare a resolution here without a call.

@astearns
Copy link
Member

I prefer we just fix it - it's purely editorial.

@tabatkins
Copy link
Member

Yeah just fix it.

@svgeesus
Copy link
Contributor

svgeesus commented Nov 4, 2019

This can be just fixed. The edit should be made to the copy of the PR that becomes the Rec, as well as in the ED bikeshed source.
The editorial change will be noted in the director's decision to the AC.

@frivoal frivoal added Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. Tracked in DoC labels Nov 11, 2019
@frivoal
Copy link
Collaborator

frivoal commented Nov 11, 2019

Fixed in the ED for level 1 and 2, and included in the (new) DoC:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AC Review Flags (when known as such) comments filed during formal AC reviews. Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-contain-1 css-contain-2 Current Work Tracked in DoC
Projects
None yet
Development

No branches or pull requests

5 participants