Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-pseudo-4] Painting selection background outside inline replaced content #4624

Closed
fantasai opened this issue Dec 22, 2019 · 4 comments
Closed

Comments

@fantasai
Copy link
Collaborator

@TalbotG noticed that Blink paints the area below a baseline-aligned highlighted image, but Firefox does not. Currently the spec only allows painting highlights within the border box of an image; should we adjust it to allow painting within the full height of the line box for inline replaced elements or somesuch?

@fantasai fantasai added the css-pseudo-4 Current Work label Dec 22, 2019
@TalbotG
Copy link
Collaborator

TalbotG commented Jan 6, 2020

Blink paints the area below a baseline-aligned highlighted image, but Firefox does not.

Test:
http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/active-selection-045-new.html

Expected result:
http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/reference/ref-nothing-below.xht

@kojiishi
Copy link
Contributor

kojiishi commented Jan 7, 2020

This is intentional, Blink wants to paint the whole line box, and also gaps between lines when lines wrap.

I believe WebKit has the same behavior too, no? @litherum

@TalbotG
Copy link
Collaborator

TalbotG commented Jan 7, 2020

Epiphany Technological Preview 3.34.0-32-g514d1bfb6 (WebKitGTK 2.26.1) has the same behavior as Blink (Chromium 78 and 81); it paints the whole line box.

@fantasai
Copy link
Collaborator Author

Fixed in a414c09 via #5395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants