Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-tables] Fixup rewrite #466

Closed
gregwhitworth opened this issue Sep 13, 2016 · 1 comment
Closed

[css-tables] Fixup rewrite #466

gregwhitworth opened this issue Sep 13, 2016 · 1 comment
Assignees
Labels
css-tables-3 Current Work

Comments

@gregwhitworth
Copy link
Contributor

Compat Issues: No

Description:
The text was rewritten but the css 2.1 behavior was preserved.
The creation of the table-wrapper box was added to the algorithm.

Proposed Option:
Accept new text.

Reason was it was very confusing to read with all the variable usage, we decided to utilize the definitions to make it more clear. Here is an example of the editorial change:

For each 'table-cell' box C in a sequence of consecutive internal table and 'table-caption' siblings, if C's parent is not a 'table-row' then generate an anonymous 'table-row' box around C and all consecutive siblings of C that are 'table-cell' boxes.

To this more concise phrasing:

An anonymous table-row box must be generated around each sequence of consecutive table-cell box whose parent is not a table-row.

Another example:

If a box B is an anonymous inline containing only white space, and is between two immediate siblings each of which is either an internal table box or a 'table-caption' box then B is treated as if it had 'display: none'.

If a child C of a tabular container P is an anonymous inline box that contains only white space, and its immediately preceding and following siblings, if any, are proper table descendants of P and are either 'table-caption' or internal table boxes, then it is treated as if it had 'display: none'. […]

To this:

Anonymous inline boxes which contains only white space and are between two immediate siblings each of which is a table-non-root box, are treated as if they had display: none.

Anonymous inline boxes which contain only white space, are the first and/or last child of a tabular container, and whose immediate sibling (if any) is a table-non-root box, are treated as if they had display: none.

This could be considered as an editorial change, but the text is so visibly different we wanted to call attention to it; we don't necessarily need a resolution.

Testcases:
https://github.com/w3c/csswg-test/blob/css-tables/work-in-progress/microsoft/css-tables/table-model-fixup.html

@gregwhitworth gregwhitworth added the css-tables-3 Current Work label Sep 13, 2016
@gregwhitworth
Copy link
Contributor Author

Add a note regarding that if this is wrong - then please report them and ref 2.2

@gregwhitworth gregwhitworth self-assigned this Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-tables-3 Current Work
Projects
Development

No branches or pull requests

1 participant