New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"contain exactly" should be a defined term #4950
Comments
How about changing
to
That would seem to cover it, although maybe "axis aligned" and the bit about ignoring transforms and positioning is overkill. The part about fragmentation does seem important though. |
I think "axis-aligned" introduces the question of which axis, unless that's already a defined term somewhere. Ignoring transforms seems tricky to me: What if the transform rotates all the ruby bases' margin boxes together by some value, say 15º? Then the containing box is also the 15º rotated box, right? Or is it? What if the transform rotates each ruby base's margin box separately by, say, 30º about the centre of each box? Then the containing box is not rotated but is sized to take into account the rotated base boxes, i.e. it would be a bit bigger, right? (or wrong?) Seems to me like the requirements are:
|
both: horizontal and vertical. i.e. not diagonal. Clearly, I'm confusing things more than helping with that statement then, so let's drop it.
Doing anything other than ignoring transforms would be hard. transforms don't affect layout in any way, it would be really weird if they did here. They're always applied after the fact. So I don't think it should be controversial to ignore them. I was wondering if it was so obvious that they would be ignored that it wasn't even worth stating. I guess it's not that obvious then, so it does seem worth stating. |
OK that makes things much simpler then, if it is clear that this operation of laying out ruby happens before any transforms, then we need the rectangle that:
|
From #4938, I noticed the phrase "contain exactly" was used but not defined. I imagine it is intended to mean that it is the smallest size possible that completely contains the margin boxes, but it would be worth being explicit about this, since any extension relative to that size would still contain the boxes.
It is probably implicit that the result is intended to be a simple rectangle, but given that the union of boxes being contained might not be a simple rectangle, we should also make that explicit.
Originated from post by @nigelmegitt in #4938
The text was updated successfully, but these errors were encountered: