Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-animations-1] Inconsistent default document timeline in Animatable interface #5701

Closed
hiikezoe opened this issue Nov 6, 2020 · 1 comment

Comments

@hiikezoe
Copy link

hiikezoe commented Nov 6, 2020

In animate() method section;

if timeline member of options is missing, be the default document timeline of the node document of the element on which this method was called

In KeyframeAnimationOptions dictionary member section;

If missing, the default document timeline of the Document associated with the Window that is the current global object is used

I believe the former is correct and that's what Firefox and Chrome do currently.
@birtles @majido

@birtles
Copy link
Contributor

birtles commented Nov 8, 2020

Good catch. I think the text in the animate() method description actually overrides the description in KeyframeAnimationOptions (since it says what to do when that member is missing) so we should probably just drop the "If missing..." sentence from the description of KeyframeAnimationOptions.timeline.

@birtles birtles closed this as completed in b96b58f Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants