Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-masking] initial value of mask-repeat and mask-position #599

Closed
CJKu opened this issue Oct 13, 2016 · 5 comments
Closed

[css-masking] initial value of mask-repeat and mask-position #599

CJKu opened this issue Oct 13, 2016 · 5 comments

Comments

@CJKu
Copy link

CJKu commented Oct 13, 2016

https://drafts.fxtf.org/css-masking-1/#the-mask-repeat
Name: mask-repeat
Initial: no-repeat
Initial value in blink/webkit: repeat
https://drafts.fxtf.org/css-masking-1/#propdef-mask-position
Name: mask-position
Initial: center
Initial value in blink/webkit: 0%

I filed issues onto WebKit Bugzilla & chromium bug tracker to ask them following spec. Apple has no action on it[1]. Google changed mask-repeat initial value to no-repeat and reverted because of a regression on twitter[2].
Gecko turn on image-mask on nightly/ aurora channel(engineer version). Following the spec, we received several regression reports as well[3].

So, we either need to persuade all browser vendors changing their initial value by what spec defined(and fix all regression on each web site), or we probably should change the spec.

Any thought?

[1] https://bugs.webkit.org/show_bug.cgi?id=159866
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=628968
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=1308963

@dbaron dbaron changed the title [css masing] initial value of mask-repeat and mask-position [css-masking] initial value of mask-repeat and mask-position Oct 13, 2016
@dbaron dbaron added the Agenda+ label Oct 13, 2016
@tabatkins
Copy link
Member

Resolution was to change the spec to match the WebKit/Chrome behavior.

@svgeesus
Copy link
Contributor

svgeesus commented Oct 26, 2016

Why is this issue on the csswg github and not the fxtf github with all the other masking-1 issues?
https://github.com/w3c/fxtf-drafts/labels/css-masking-1

@SebastianZ
Copy link
Contributor

Why is this issue on the csswg github and not the fxtf github with all the other masking-1 issues?
https://github.com/w3c/fxtf-drafts/labels/css-masking-1

I've created w3c/fxtf-drafts#111 for this now, so the spec. is finally changed according to the implementations.

Resolution was to change the spec to match the WebKit/Chrome behavior.

I couldn't find the related minutes. If you find them, please post them in the issue mentioned above.

Sebastian

@xfq
Copy link
Member

xfq commented Aug 13, 2018

This issue seems to be fixed in w3c/fxtf-drafts@bdb4c31

Should we close it?

@svgeesus
Copy link
Contributor

Closed as the edits were made (in 2018!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants