Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-multicol][css-align] row-gap should apply to multi-column containers too #6746

Open
MatsPalmgren opened this issue Oct 19, 2021 · 2 comments
Labels
css-align-3 Current Work css-multicol-1 Current Work

Comments

@MatsPalmgren
Copy link

CSS Box Alignment says:

multi-column containers [...] row-gap does not currently apply.
https://drafts.csswg.org/css-align-3/#gap-multicol

I think it should apply to multi-column containers too, specifically between column-span elements and the set of columns above/below. I'm working on a prototype implementation of gap decorations in Gecko, which adds row-rule properties, which will render between the "rows" created by spanners. So it's reasonable to change row-gap so that it applies to multi-column containers too. (I'll file a separate issue on the gap decorations proposal.)

Like for Grid and Flexbox gaps, the row-gap should be applied between margin-boxes, and it doesn't collapse or merge with any margins. It creates space in addition to any margins on the spanner.

Here's an example multi-column container with row-gap and (purple) row-rules:
image

@rachelandrew
Copy link
Contributor

I'm hoping to spec block direction overflow for multicol containers in level 2 of the spec, in which case the row-gap (and any decoration) would be between the new sets of column boxes in the block dimension.

Given that it is already possible to make space around a spanner using margins, my initial thought is that we should maintain the gap property for this use rather than using it for spanners.

@MatsPalmgren
Copy link
Author

I don't see a conflict there (assuming I'm imagining how your "block direction overflow" thing would work correctly). I tend to think row-gap/rules should appear in all "block axis divisions" in a column layout. I elaborate a bit more in the draft spec about how it would work for column-span: <integer> for example.

@tabatkins tabatkins added css-align-3 Current Work css-multicol-1 Current Work labels Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-align-3 Current Work css-multicol-1 Current Work
Projects
None yet
Development

No branches or pull requests

3 participants