Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align] The 'alignment baseline' is undefined for Grid/Flexbox #798

Closed
MatsPalmgren opened this issue Dec 13, 2016 · 3 comments
Closed
Labels
css-inline-3 Current Work

Comments

@MatsPalmgren
Copy link

https://drafts.csswg.org/css-align-3/#baseline-export says

The alignment baseline is one of these, usually the dominant baseline associated with the shared alignment context. (See the dominant-baseline and alignment-baseline properties in [CSS-INLINE-3].)

https://drafts.csswg.org/css-inline/#dominant-baseline-property says

Applies to: block containers and inline boxes

So, it's undefined which 'alignment baseline' to use for grid/flex items since dominant-baseline doesn't apply to grid/flexbox containers. (I'm assuming for now that it is the dominant-baseline:auto behavior that applies by default. Please correct me if I'm wrong.)

@fantasai
Copy link
Collaborator

fantasai commented Feb 2, 2017

Good point. I checked in an initial fix to this to css-inline; it'll need some more cleanup, though.

@dbaron
Copy link
Member

dbaron commented Mar 15, 2017

I find it a bit curious that baseline-shift applies to fewer elements than alignment-baseline and dominant-baseline. Though perhaps it makes sense???

@fantasai
Copy link
Collaborator

fantasai commented Mar 17, 2017

Fixed. File an issue if it shouldn't. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-inline-3 Current Work
Projects
None yet
Development

No branches or pull requests

3 participants