Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-view-transitions-1] UA CSS should add transform-origin to view-transition-group #8370

Closed
khushalsagar opened this issue Jan 27, 2023 · 2 comments
Labels
css-view-transitions-1 View Transitions; Bugs only

Comments

@khushalsagar
Copy link
Member

khushalsagar commented Jan 27, 2023

The UA CSS should have the following rule on view-transition-group:

transform-origin: top left;

This is because the dynamic transform computed here should be with respect to the top left corner of the element. Given that the element's bounds will also animate during the transition, it makes sense.

@khushalsagar khushalsagar added the css-view-transitions-1 View Transitions; Bugs only label Jan 27, 2023
@khushalsagar khushalsagar changed the title [css-view-transitions-1] UA CSS adds transform-origin to view-transition-group [css-view-transitions-1] UA CSS should add transform-origin to view-transition-group Jan 27, 2023
@khushalsagar khushalsagar added Async Resolution: Proposed Candidate for auto-resolve with stated time limit Agenda+ labels Feb 7, 2023
@astearns astearns removed the Async Resolution: Proposed Candidate for auto-resolve with stated time limit label Feb 21, 2023
@astearns
Copy link
Member

I’d like to see at least one other person agree to the proposed resolution here before trying the async route. What happens when authors override the UA default? Are there no writing mode or direction concerns with a top left default?

@khushalsagar
Copy link
Member Author

What happens when authors override the UA default? Are there no writing mode or direction concerns with a top left default?

Devs changing the UA default would lead to unpredictable behaviour no matter what the default is. Since the transform value computed by the UA for the group will assume a particular value for transform-origin. The writing mode/direction is a good point. Its not intuitive for the transform to be relative to the top-left corner for RTL writing mode.

I'm going to close this issue then. The current spec uses the default value of transform-origin which is relative to the center of the box. That makes most sense in that it is immune to writing mode/direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-view-transitions-1 View Transitions; Bugs only
Projects
None yet
Development

No branches or pull requests

2 participants