Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-cascade] Define animation type of all as not animatable #8414

Closed
cdoublev opened this issue Feb 8, 2023 · 3 comments
Closed

[css-cascade] Define animation type of all as not animatable #8414

cdoublev opened this issue Feb 8, 2023 · 3 comments
Labels
Closed as Retracted When the person who raised the issue thinks that there's no issue after all. css-cascade-3

Comments

@cdoublev
Copy link
Collaborator

cdoublev commented Feb 8, 2023

Some shorthands that have non-animatable sub-properties are defined with not animatable as the value of the field Animation Type in their definition table, instead of see individual properties:

all seems to be the only shorthand that have both animatable and non-animatable properties. I assume it is not animatable because Chrome/FF do not seem to animate it. Also, I think it would be non-trivial to filter declarations of its non-animatable properties during their expansion.

In practice, a shorthand animation type can be resolved from the animation types of its sub-properties, but it would be clearer to define it as non animatable.

@Loirooriol
Copy link
Contributor

IMO shorthands should just expand into longhands, and then each longhand can animate according to its type, or not.

WebKit is able to animate all: testcase. background-color animates continuously, while width and height animate discretely between 100px and auto.

@tabatkins
Copy link
Member

Agreed, shorthands should be treated as an expansion to their longhands and animated as much as possible.

@cdoublev
Copy link
Collaborator Author

cdoublev commented Feb 8, 2023

Right, step 3 of resolving the effect value of a keyframe) should discard declarations of non-animatable properties.

Thanks for your answers.

@cdoublev cdoublev closed this as completed Feb 9, 2023
@fantasai fantasai added css-cascade-3 Closed as Retracted When the person who raised the issue thinks that there's no issue after all. labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed as Retracted When the person who raised the issue thinks that there's no issue after all. css-cascade-3
Projects
None yet
Development

No branches or pull requests

4 participants