Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-animations-2][scroll-animations-1] Avoid including properties that should be interpolated at boundaries when adding neutral keyframes #8491

Closed
kevers-google opened this issue Feb 23, 2023 · 2 comments
Labels
Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-animations-2 scroll-animations-1 Current Work

Comments

@kevers-google
Copy link
Contributor

Steps 7 and 8 in https://drafts.csswg.org/css-animations-2/#keyframes outline the procedure for adding initial and final keyframes for properties that are missing at the boundaries. This procedure should be updated such that properties that are missing at 0 or 1, but which should be interpolated at the boundary are not included.

The set of "from" properties should include all properties found in a keyframe with offset <= 0.
Conversely, the set of "to" properties should include all properties found in a keyframe with offset >= 0.

Keyframes with a timeline offsets can result in computed offsets being outside the 0 to 1 range and should be interpolated at the boundary (see #7825).

@flackr
Copy link
Contributor

flackr commented Feb 23, 2023

I think this is already covered by the patch to the spec in scroll-animations-1 Appendix Named Timeline Range Keyframe Selectors where it says:

in these cases the automatic from (0%) and to (100%) keyframes are only generated for properties that don’t have keyframes at or earlier than 0% or at or after 100% (respectively).

@kevers-google
Copy link
Contributor Author

Ah perfect. Didn't check there.

@flackr flackr closed this as completed Mar 10, 2023
@flackr flackr added css-animations-2 Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. scroll-animations-1 Current Work labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-animations-2 scroll-animations-1 Current Work
Projects
None yet
Development

No branches or pull requests

2 participants