Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-values-4] Wrong determined type for asin, acos, atan, and atan2 #9034

Closed
AtkinsSJ opened this issue Jul 5, 2023 · 2 comments · Fixed by #9043
Closed

[css-values-4] Wrong determined type for asin, acos, atan, and atan2 #9034

AtkinsSJ opened this issue Jul 5, 2023 · 2 comments · Fixed by #9043

Comments

@AtkinsSJ
Copy link
Contributor

AtkinsSJ commented Jul 5, 2023

In https://drafts.csswg.org/css-values-4/#calc-type-checking, the determined types of all of the trigonometric functions are specified here:

sign() sin() cos() tan() asin() acos() atan() atan2() pow() sqrt() log() exp()
«[ ]» (empty map).

This means that asin(), acos(), atan(), and atan2() will all claim to return a <number>, when they actually return an <angle>. I believe these four should all return «[ "angle" → 1 ]» instead.

@tabatkins
Copy link
Member

Correct; I might have written that when the functions were defined just over radians? Or I just messed up. Anyway yeah, the arc functions should return angles.

@cdoublev
Copy link
Collaborator

cdoublev commented Jul 6, 2023

The wront type is from cc71452, which fixed #7486. Sorry, because I continued to expect these functions to output an angle but I did not spot the mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants