-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-rhythm][css-values-4] Figure out the interaction between line-height-step and the lh and rlh units #937
Comments
The line-height-step property changes the algorithm to compute the line height. If |
Currently, It seems to me that if we wanted to depend on the actual adjusted line height taking the content into account, we would need to do everything at used value time. However, at computed value time, it should be possible to take the height of an empty line as adjusted by line-height-step. That sounds better to me than having units that resolved at used value time, which seems like a pretty big headache. |
(sorry for closing and reopening. I just meant to comment and mis-clicked). |
Also, we need to define what the |
Any use cases to prefer that? |
Agreed with frivoal on the points. Koji, we can't use used-value inputs into units, because they compute to absolute lengths at computed value time... |
Blink has the same constraints, can't use used-value to compute styles, that's ok. I'm just curious, when we have a choice to round up during the style recalc, and @frivoal preferred not to do that IIUC, that what the reasons behind it. |
|
I see, you're talking about cycles. Can we do something like what we do for |
This was discussed during a conf call, and generally agreed about. Someone now needs to write the proposed edits. (Could be me, @fantasai @tabatkins ...) |
What was the agreement referred to above? |
Ohh, talk about a backlog… sorry for the "small" delay. I believe the relevant minutes are these ones:
The details are in the minutes. |
The line-height-step property influences the line height.
The
lh
andrlh
units depend on the line height.We need to define if the property influences the units. I think it should.
The text was updated successfully, but these errors were encountered: