Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-fonts-4] <generic-family> should not accept <string> and unrestricted <custom-ident>+ #9410

Closed
cdoublev opened this issue Sep 26, 2023 · 3 comments
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-fonts-4 Current Work

Comments

@cdoublev
Copy link
Collaborator

cdoublev commented Sep 26, 2023

Follow-up on #6770 (comment).

<generic-family> went from accepting a restricted list of keywords (generic family names) to accepting either generic(<custom-ident>+), <string>, or (unrestricted) <custom-ident>+.

But from reading across the issue, I suspect the intent was for it to only acquire generic(<custom-ident>+). Therefore in the comment, I suggested <generic-family> = generic(<custom-ident>+) | <generic-family-name>.

Generic family names would be defined for <generic-family-name> (to allow deriving <generic-family-name> = serif | sans-serif | ... from scraped <dfn>s).

@cdoublev cdoublev added the css-fonts-4 Current Work label Sep 26, 2023
@svgeesus
Copy link
Contributor

It should really have been generic(<custom-ident>) i.e. a single identifier inside the function. Like generic(kai)

But there is a need to do two things: define the syntax for the function, in general, and also define the current list of generic font families. The older ones don't use the functional syntax while the new ones will.

@svgeesus
Copy link
Contributor

@cdoublev
Copy link
Collaborator Author

Fixed by 69f7f7a.

@svgeesus svgeesus added Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-fonts-4 Current Work
Projects
None yet
Development

No branches or pull requests

2 participants