Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-inline-3] Extend “applies to” for SVG text #5149

Merged
merged 1 commit into from Jun 10, 2020

Conversation

AmeliaBR
Copy link
Contributor

@AmeliaBR AmeliaBR commented Jun 2, 2020

Closes #3411
See issue for discussion/reasoning & differences from SVG 1.

Bikeshed error that needs fixing:
the “current text position” definition from SVG text
is not being exported in a way that Bikeshed is picking up,
even with hints about which spec to look for it in.
(@tabatkins, can I fix this here, or do I need to add some attributes to the SVG spec?)

Changes should be copied over to css-inline-4 after review.

@tabatkins
Copy link
Member

"current text position" is definitely present in the db and linkable, but it's not exported, so you'll need to specify the spec to override that and link it anyway.

You can either do that inline <l spec=svg2>[=current text position=]</l> or by putting it in <pre class=link-defaults>.

@AmeliaBR AmeliaBR marked this pull request as ready for review June 10, 2020 02:37
@AmeliaBR
Copy link
Contributor Author

or by putting it in <pre class=link-defaults>

I had tried that, but I hadn't used the correct shortname for the SVG2 spec. Fixed now.

@fantasai, ready to merge if you're OK with how I handled the properties with inconsistent implementations. Note that this is only the edits to CSS Inline 3, you'll want to port to Inline 4

Closes w3c#3411
See issue for discussion/reasoning & differences from SVG 1.

Changes should be copied over to css-inline-4
after review.
@AmeliaBR AmeliaBR force-pushed the fix-3411-css-inline-svg-applies branch from 395b750 to 743f091 Compare June 10, 2020 02:57
@AmeliaBR
Copy link
Contributor Author

@fantasai, ready to merge if you're OK

Actually, NOW it's ready to merge, after I pulled in your latest edits & fixed the merge conflicts…

You probably want to review carefully.

@fantasai fantasai merged commit 0d8fff5 into w3c:master Jun 10, 2020
@fantasai
Copy link
Collaborator

Sorry, thanks! ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-inline] CSS properties appply to SVG elements
3 participants