Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move test-as-you-commit text? #88

Closed
samuelweiler opened this issue Apr 13, 2020 · 5 comments
Closed

move test-as-you-commit text? #88

samuelweiler opened this issue Apr 13, 2020 · 5 comments

Comments

@samuelweiler
Copy link
Member

The test as you commit text in section 2 seems partially redundant with the success criteria text is section 4. Maybe move it to section 4? (e.g. test-as-you-commit at CR; two implementations for PR)

I like the use of the blockquote rather than just repeating boilerplate - that's clever. Please explain the origin of the blockquote in text - not just in the text of the URL. Say it's W3C published testing policy. Make the URL into a link! Consider dropping the last sentence from the block quote, since that special case doesn't add much value in this charter (though we know it applies).

@xfq xfq closed this as completed in 5338381 Apr 15, 2020
@samuelweiler
Copy link
Member Author

It looks like the text was moved but the origin wasn't explained for a working link added.

@samuelweiler samuelweiler reopened this Apr 15, 2020
@samuelweiler
Copy link
Member Author

Looking further, the text was moved into "coordination", which makes no sense to me. I was suggesting it be merged into the success criteria text which is section 3. Not sure if the section numbering changed or I made a mistake above.

@xfq
Copy link
Member

xfq commented Apr 16, 2020

There is already a link to the page (i.e., the "test as you commit" text), and I'm not sure how to make the cite attribute of blockquote a link.

@xfq
Copy link
Member

xfq commented Apr 20, 2020

@samuelweiler Would you please confirm whether #92 is good enough?

@xfq
Copy link
Member

xfq commented Apr 24, 2020

Hearing no reply, I have just merged the PR.

@xfq xfq closed this as completed Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants