Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in "Note on Persistence" in DID Syntax section #504

Closed
shigeya opened this issue Dec 15, 2020 · 7 comments
Closed

Issues in "Note on Persistence" in DID Syntax section #504

shigeya opened this issue Dec 15, 2020 · 7 comments
Assignees
Labels
pr-exists There is an open PR to address this issue

Comments

@shigeya
Copy link
Contributor

shigeya commented Dec 15, 2020

Regarding the 3.1 DID Syntax Section, there is a note on persistence.
I observe two issues.

  • Terminology UUID is mentioned only once in the entire document. Do we need to have the UUID terminology entry just for this description?
  • I think this note does not belong to the "DID Syntax" section

I propose eliminating UUID terminology entry and adding a reference to UUID since mentioning UUID itself seems useful.

Where to relocate is a question. I'm currently re-reviewing whole "Notes" and related paragraphs; I observe there are some paragraphs we want to transform into Notes, and the others require relocation. I'll post another issue to discuss how notes need to be reorganized after the review.

@kdenhartog
Copy link
Member

Related to this work is currently being revised as well by @talltree in #457

I think we can incorporate this feedback into that PR and close once #457 is merged.

@shigeya
Copy link
Contributor Author

shigeya commented Dec 15, 2020

@kdenhartog I see. I will check #457

@shigeya
Copy link
Contributor Author

shigeya commented Dec 22, 2020

@kdenhartog Read thorough #457. Looks like it already became beyond just a note and it needs relocation. I will comment in #457.

@msporny
Copy link
Member

msporny commented Jan 12, 2021

This issue will be closed once PR #457 is merged.

@talltree
Copy link
Contributor

Per @shigeya's suggestion, as well as the feedback in the last DID WG special topic call, I revised #457 to move it to the Security Considerations section.

@rhiaro rhiaro added the pr-exists There is an open PR to address this issue label Jan 25, 2021
@shigeya
Copy link
Contributor Author

shigeya commented Jan 31, 2021

As PR #457 and follow-up PR #574 discussing persistence and close-to-be-approved PR #574 relocate the text to the security section, this issue can be closed once PR #574 merges.

@msporny
Copy link
Member

msporny commented Feb 2, 2021

PR #574 has been merged, closing.

@msporny msporny closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-exists There is an open PR to address this issue
Projects
None yet
Development

No branches or pull requests

5 participants