Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are confusing, consider refactoring #17

Closed
OR13 opened this issue Dec 5, 2020 · 2 comments
Closed

Tests are confusing, consider refactoring #17

OR13 opened this issue Dec 5, 2020 · 2 comments

Comments

@OR13
Copy link
Contributor

OR13 commented Dec 5, 2020

I have improved on the initial approach taken here, in https://github.com/transmute-industries/vc.transmute.world

I am currently hosting a test server, which can be used to run the tests, their interfaces are substantially simpler:

https://github.com/transmute-industries/vc.transmute.world/blob/master/packages/jest-test-server/suites/issuer-api/issuer-api.spec.js

If its desired, I can refactor this repo to support this pattern AND host a version fo the suite that can be used to request tests on demand.

@peacekeeper
Copy link
Contributor

I think this would make sense. Even though I have spent quite some time trying to contribute to this test suite (see #12), it's still not entirely clear to me how it can be used against an actual implementation.

With the earlier VC HTTP API test suite you built, both extending the test suite, and testing a concrete implementation felt much simpler.

(That's my subjective view as someone who's not really a JavaScript person...)

@OR13
Copy link
Contributor Author

OR13 commented Jan 23, 2021

refactoring complete, closing

@OR13 OR13 closed this as completed Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants