Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Example 15 #1463

Merged
merged 7 commits into from Mar 2, 2022
Merged

Fix typo in Example 15 #1463

merged 7 commits into from Mar 2, 2022

Conversation

andrea-perego
Copy link
Contributor

Addresses #1459

@andrea-perego andrea-perego added dcat Editorial feedback Issues stemming from external feedback to the WG labels Feb 25, 2022
@andrea-perego andrea-perego added this to In progress in DCAT Sprint: Editorial revisions via automation Feb 25, 2022
@andrea-perego andrea-perego added this to In progress in DCAT Sprint: Feedback via automation Feb 25, 2022
@andrea-perego andrea-perego added this to the DCAT3 4PWD milestone Feb 25, 2022
@andrea-perego andrea-perego linked an issue Feb 25, 2022 that may be closed by this pull request
@andrea-perego andrea-perego marked this pull request as ready for review February 25, 2022 18:58
@riccardoAlbertoni
Copy link
Contributor

We might want to propagate the change in the rdf example files available under the directory dcat/examples and in the text explaining example 15.

Moreover, I have noticed that in the REC we have used three different name spaces for example URIS: https://example.org/, http://example.org/, and https://dcat.example.org/
Perhaps we should consider to use one only. In case, do we want to deal with the example namespace uniformity in a separate issue?

DCAT Sprint: Editorial revisions automation moved this from In progress to Review in progress Feb 25, 2022
Copy link
Member

@agbeltran agbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Riccardo's comments - line 4020 needs the same change: <code>https://example.org/PoelenJorritHID</code> to <code>https://dcat.example.org/PoelenJorritHID</code>

DCAT Sprint: Feedback automation moved this from In progress to Review in progress Feb 25, 2022
@andrea-perego
Copy link
Contributor Author

We might want to propagate the change in the rdf example files available under the directory dcat/examples and in the text explaining example 15.

Could you please take care of it, @riccardoAlbertoni ?

Moreover, I have noticed that in the REC we have used three different name spaces for example URIS: https://example.org/, http://example.org/, and https://dcat.example.org/ Perhaps we should consider to use one only. In case, do we want to deal with the example namespace uniformity in a separate issue?

Yes, I think we'd better open a new issue on it.

@andrea-perego
Copy link
Contributor Author

I agree with Riccardo's comments - line 4020 needs the same change: <code>https://example.org/PoelenJorritHID</code> to <code>https://dcat.example.org/PoelenJorritHID</code>

Thanks, @agbeltran . Just fixed via 3b6f1f3

@andrea-perego
Copy link
Contributor Author

I agree with Riccardo's comments - line 4020 needs the same change: <code>https://example.org/PoelenJorritHID</code> to <code>https://dcat.example.org/PoelenJorritHID</code>

Thanks, @agbeltran . Just fixed via 3b6f1f3

@agbeltran , could you please check if your happy with this revision, and add your review?

DCAT Sprint: Editorial revisions automation moved this from Review in progress to Reviewer approved Mar 2, 2022
DCAT Sprint: Feedback automation moved this from Review in progress to Reviewer approved Mar 2, 2022
@agbeltran agbeltran merged commit a24b2bc into gh-pages Mar 2, 2022
DCAT Sprint: Editorial revisions automation moved this from Reviewer approved to Done Mar 2, 2022
DCAT Sprint: Feedback automation moved this from Reviewer approved to Done Mar 2, 2022
@agbeltran agbeltran deleted the dcat-issue-1459 branch March 2, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dcat Editorial feedback Issues stemming from external feedback to the WG
Development

Successfully merging this pull request may close these issues.

Example 15: mistake in the used URIs?
5 participants