Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should undo/redo be beforeInput events? #30

Closed
BenjamP opened this issue Dec 10, 2014 · 2 comments
Closed

Should undo/redo be beforeInput events? #30

BenjamP opened this issue Dec 10, 2014 · 2 comments
Milestone

Comments

@BenjamP
Copy link

BenjamP commented Dec 10, 2014

How do we determine when we need a new event? Or is everything just going to use beforeInput? This also applies to custom events if we support them, like 'checkout' event or 'save' event.
-From MS Office Team

@BenjamP BenjamP added this to the V1.1 milestone Jan 28, 2015
@johanneswilm
Copy link
Contributor

Is there any advantage to have custom events handled by the browser rather than directly through the client?

@johanneswilm
Copy link
Contributor

As for custom events: We already have ways to listen for key clicks in Javascript and it is fairly easy to have set up one way of listening to a series of key combinations and then initiate various things, such as "Save", "go to next", "close", etc. .

Maybe there are other good use cases for this that I cannot think off, but it seems like that should then be a spec of its own and not depend on whether or not there is a contenteditable=typing element on the page.

I will close this for now, but please reopen if this has been misunderstood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants