Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeInput: Rename "inputCharacter" to "inputText" #119

Closed
yosinch opened this issue Mar 16, 2016 · 2 comments
Closed

beforeInput: Rename "inputCharacter" to "inputText" #119

yosinch opened this issue Mar 16, 2016 · 2 comments

Comments

@yosinch
Copy link

yosinch commented Mar 16, 2016

One user action can insert multiple characters instead of one character. "Character" suffix mislead web authors.

@chong-z
Copy link

chong-z commented Apr 7, 2016

Agree that using insertText is better since it's a more standard command name defined in https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand#Commands. (See discussion in #79 for the list of inputType to start with)

@johanneswilm
Copy link
Contributor

Hey, @choniong , I couldn't merge your PR due to some restriction set in the W3C's github group, but I made the change nevertheless, as there didn't seem to be any opposition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants