-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide on ideal "waitingforkey" event behavior when update() doesn't resume playback #98
Comments
I'd like feedback from authors, but I'm leaning towards 1) always firing the event and b) removing the text to ensure consistent behavior. This seems like the easiest to implement and test, and we have already identified concerns related to that text. |
Note that the following Note related to the " may choose to skip " statement in
I also have more general concerns about how the algorithms wait and resume playback in #100. |
The Sapporo F2F attendees discussed this item and agreed with what @ddorwin proposed in "1) always firing the event".
There was a preference by Sapporo F2F attendees for removing the above text as suggested by @ddorwin. It would still would be good to get application developers feedback on these proposed changes. @mwatson2 and @steelejoe will attempt to get such feedback. |
Feedback from our application developers aligns with the above: send the event after every |
I agree with @ddorwin's proposal here. |
@ddorwin's proposal sounds good to me. |
Note: I do not believe there will be multiple |
This issue is related to the user agent behavior when playback is already blocked waiting for a key (the
"waitingforkey"
event has already been fired) andupdate()
is called but does not unblock playback (i.e. by providing the needed key). (This was originally raised in the latter comments of issue #42.) We need to decide on the desired application-visible behavior then make any related changes to the algorithms.Note: The
update()
call may not have provided any keys. For example, it could have been part of a series of messages to obtain a key.Currently, the Attempt to Resume Playback If Necessary algorithm runs the Encrypted Block Encountered algorithm, which I believe would get to the 'Run the queue a "waitingforkey" event algorithm on the media element' step, resulting in another
"waitingforkey"
event.However, the call sites for "Attempt to Resume Playback If Necessary algorithm" say "The user agent may choose to skip this step if it knows resuming will fail." Thus, the behavior could be inconsistent, even within key system implementations.
Two questions:
"waitingforkey"
event desirable? (Note: There may be further events on subsequentupdate()
calls.)"waitingforkey"
event is always called by requiring that the Attempt to Resume Playback If Necessary algorithm always runs?The text was updated successfully, but these errors were encountered: