Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about "-epub-text-combine-horizontal" property #247

Closed
toshiakikoike opened this issue Nov 9, 2022 · 2 comments · Fixed by #249
Closed

about "-epub-text-combine-horizontal" property #247

toshiakikoike opened this issue Nov 9, 2022 · 2 comments · Fixed by #249
Assignees

Comments

@toshiakikoike
Copy link
Contributor

at /epub-tests/tree/main/tests)/css-epub-text-combine-horizontal/
"-epub-text-combine-horizontal" property are used.
But, I think this property is wrong for EPUB CSS.

if with "-epub-" prefix, then right property is
"-epub-text-combine:horizontal;"
or if latest right property is
"text-combine-upright:all;"

@wareid
Copy link
Contributor

wareid commented Nov 9, 2022

Will take a look! Thanks @toshiakikoike

@wareid wareid linked a pull request Nov 9, 2022 that will close this issue
@wareid
Copy link
Contributor

wareid commented Nov 9, 2022

@toshiakikoike I've added two new tests to the file to address the -epub-text-combine case, which is technically deprecated in the specification (why I didn't include it) but it's there to be tested.

These tests don't use the text-combine- properties because that would be a test for CSS, not EPUB :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants