Skip to content

Commit

Permalink
fix: remove undefined isHTML5 field from the JSON report
Browse files Browse the repository at this point in the history
See #1515
  • Loading branch information
rdeltour committed Jul 6, 2023
1 parent 65828c2 commit 00b1d20
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 16 deletions.
7 changes: 0 additions & 7 deletions src/main/java/com/adobe/epubcheck/reporting/ItemMetadata.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import com.adobe.epubcheck.util.FeatureEnum;

@SuppressWarnings("FieldCanBeLocal")
public class ItemMetadata implements Comparable<ItemMetadata>
{
@JsonProperty
Expand All @@ -34,8 +33,6 @@ public class ItemMetadata implements Comparable<ItemMetadata>
@JsonProperty
private Integer navigationOrder = null;
@JsonProperty
private boolean isHTML5;
@JsonProperty
private Boolean isFixedFormat = null;
@JsonProperty
private boolean isScripted;
Expand All @@ -51,7 +48,6 @@ public class ItemMetadata implements Comparable<ItemMetadata>
private String renditionOrientation;
@JsonProperty
private String renditionSpread;
@SuppressWarnings("MismatchedQueryAndUpdateOfCollection")
@JsonProperty
private final SortedSet<String> referencedItems = new TreeSet<String>();

Expand Down Expand Up @@ -171,9 +167,6 @@ public void handleInfo(FeatureEnum feature, String value)
case SPINE_INDEX:
this.spineIndex = Integer.parseInt(value.trim());
break;
case HAS_HTML5:
this.isHTML5 = true;
break;
case SCRIPT:
if (value.equals("inline"))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
/**
* This is information about the publication in general. It is intended to be serialized into json.
*/
@SuppressWarnings({"FieldCanBeLocal", "MismatchedQueryAndUpdateOfCollection"})
class PublicationMetadata
{
@JsonProperty
Expand Down Expand Up @@ -131,12 +130,6 @@ public void handleInfo(String resource, FeatureEnum feature, String value)
this.hasFixedFormat = true;
this.isBackwardCompatible = false;
break;
case HAS_HTML5:
if (resource == null)
{
this.isBackwardCompatible = false;
}
break;
case IS_SPINEITEM:
this.nSpines++;
break;
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/com/adobe/epubcheck/util/FeatureEnum.java
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ public enum FeatureEnum
FORMAT_VERSION("format version"),
HAS_ENCRYPTION("hasEncryption"),
HAS_FIXED_LAYOUT("hasFixedLayout"),
HAS_HTML4("html 4"),
HAS_HTML5("html 5"),
HAS_MICRODATA("microdata"),
HAS_NCX("Has ncx file"),
HAS_RDFA("RDFa"),
Expand Down

0 comments on commit 00b1d20

Please sign in to comment.