Skip to content

Commit

Permalink
fix: remove "under review" notice for toc nav ordering warning
Browse files Browse the repository at this point in the history
Fix #1194
  • Loading branch information
rdeltour committed Jan 23, 2022
1 parent bc86db8 commit fe08c59
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
4 changes: 0 additions & 4 deletions src/main/java/com/adobe/epubcheck/opf/XRefChecker.java
Expand Up @@ -560,8 +560,6 @@ private void checkReadingOrder(Queue<Reference> references, int lastSpinePositio
report.message(MessageId.NAV_011,
EPUBLocation.create(ref.source, ref.lineNumber, ref.columnNumber),
(ref.type == Type.NAV_TOC_LINK) ? "toc" : "page-list", ref.value, orderContext);
report.message(MessageId.INF_001,
EPUBLocation.create(ref.source, ref.lineNumber, ref.columnNumber), "https://github.com/w3c/publ-epub-revision/issues/1283");
}
lastSpinePosition = targetSpinePosition;
lastAnchorPosition = -1;
Expand Down Expand Up @@ -590,8 +588,6 @@ private void checkReadingOrder(Queue<Reference> references, int lastSpinePositio
report.message(MessageId.NAV_011,
EPUBLocation.create(ref.source, ref.lineNumber, ref.columnNumber),
(ref.type == Type.NAV_TOC_LINK) ? "toc" : "page-list", ref.value, orderContext);
report.message(MessageId.INF_001,
EPUBLocation.create(ref.source, ref.lineNumber, ref.columnNumber), "https://github.com/w3c/publ-epub-revision/issues/1283");
}
}
lastAnchorPosition = targetAnchorPosition;
Expand Down
4 changes: 0 additions & 4 deletions src/test/resources/epub3/navigation-publication.feature
Expand Up @@ -50,13 +50,11 @@ Feature: EPUB 3 ▸ Navigation Document ▸ Full Publication Checks
Scenario: Report a `toc nav` whose links do not match the spine order
When checking EPUB 'nav-toc-unordered-spine-warning'
Then warning NAV-011 is reported
And info INF-001 is reported
And no other errors or warnings are reported

Scenario: Report a `toc nav` whose link fragments do match the document order
When checking EPUB 'nav-toc-unordered-fragments-warning'
Then warning NAV-011 is reported 2 times
And info INF-001 is reported
And no other errors or warnings are reported

Scenario: Report as a USAGE a `toc nav` which does not link to all spine items
Expand All @@ -76,13 +74,11 @@ Feature: EPUB 3 ▸ Navigation Document ▸ Full Publication Checks
Scenario: Report a `page-list nav` whose links do not match the spine order
When checking EPUB 'nav-page-list-unordered-spine-warning'
Then warning NAV-011 is reported
And info INF-001 is reported
And no other errors or warnings are reported

Scenario: Report a `page-list nav` whose links do match the document order
When checking EPUB 'nav-page-list-unordered-fragments-warning'
Then warning NAV-011 is reported
And info INF-001 is reported
And no other errors or warnings are reported


Expand Down

0 comments on commit fe08c59

Please sign in to comment.