fix: fail gracefully when running on a non-EPUB file #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running EPUBCheck on a non-EPUB package file (for instance an Office Open XML document) caused a a `NullPointerException`. It now fails gracefully with a fatal error (RSC-002) potentially followed by side-effect errors (typically RSC-001, PKG-006). Fixes #1050
karenhanson
added a commit
to karenhanson/jhove
that referenced
this pull request
Oct 21, 2020
Two changes to EPUBCheck were causing the tests to change: The first changes the error messages returned for validation of a non-EPUB: w3c/epubcheck#1134 The solution was to change the message count. The second downgrades the encrypted file message to INFO w3c/epubcheck#1136 The original implementation of the JHOVE EPUB module did not include INFO messages generated by EPUBCheck in the JHOVE report, but looking at the kinds of messages that might be listed as INFO messages I thought it might be useful to include them. The change to add INFO messages is reflected in this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running EPUBCheck on a non-EPUB package file (for instance an Office
Open XML document) caused a a
NullPointerException.It now fails gracefully with a fatal error (RSC-002) potentially followed
by side-effect errors (typically RSC-001, PKG-006).
Fixes #1050