Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report empty title elements in XHTML Content Documents #1135

Merged
merged 1 commit into from
May 1, 2020

Conversation

rdeltour
Copy link
Member

@rdeltour rdeltour commented May 1, 2020

Empty or whitespace-only title elements are disallowed in HTML:
https://html.spec.whatwg.org/#the-title-element

Nu HTML Checker checks this with Java Code, so it’s not exposed in
EPUBCheck (which only uses the Checkr’s schemas).
This change re-implements the check in Schematron.

Fixes #1093

Empty or whitespace-only `title` elements are disallowed in HTML:
  https://html.spec.whatwg.org/#the-title-element

Nu HTML Checker checks this with Java Code, so it’s not exposed in
EPUBCheck (which only uses the Checkr’s schemas).
This change re-implements the check in Schematron.

Fixes #1093
@rdeltour rdeltour added this to the 4.2.3 milestone May 1, 2020
@rdeltour rdeltour requested a review from mattgarrish May 1, 2020 08:12
@rdeltour rdeltour self-assigned this May 1, 2020
@rdeltour rdeltour merged commit f115730 into master May 1, 2020
@rdeltour rdeltour deleted the fix/1093/empty-title branch May 1, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-closing title not reported as an error when validating EPUB 3.2
2 participants