Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusion in ePubCheck 4.2.4 with ERROR(HTM-046) when checking viewport in fxl vs rfl epub #1214

Closed
JackieFei opened this issue Mar 9, 2021 · 1 comment
Assignees
Labels
status: completed Work completed, can be closed type: false-negative This issue is about invalid content being incorrectly accepted
Milestone

Comments

@JackieFei
Copy link

Test case :

  • the viewport (height or width) without proper value, such as height=705, width=

ePubCheck 4.2.4 :

  • output ERROR(HTM-046) in fixed layout epub
  • but all pass in reflowable epub with itemref properties="rendition:layout-pre-paginated".

Sample 1 :

fxl_without_viewport_width.epub.zip

content.opf

<meta property="rendition:layout">pre-paginated</meta>
<meta property="rendition:spread">landscape</meta>
<meta property="rendition:orientation">auto</meta>

Cover.xhtml

<meta name="viewport" content="height=705, width="/>

epubcheck-4.2.4 :

  • ERROR(HTM-046): Fixed format item has no viewport defined.

Sample 2 :

rfl_without_viewport_width.epub.zip

content.opf

<itemref idref="Cover.xhtml" properties="rendition:layout-pre-paginated rendition:spread-none rendition:page-spread-center"/>

Cover.xhtml

<meta name="viewport" content="height=705, width="/>

epubcheck-4.2.4 is all pass.

  • We think the rfl_without_viewport_width.epub should also output ERROR(HTM-046), or HTM-047 (Html viewport is missing height and/or width.)

reference #419

@rdeltour
Copy link
Member

rdeltour commented Mar 9, 2021

Thanks for the report @JackieFei! It looks like a false-negative indeed (an error should probably be reported).

I'll try to have a closer look for the next milestone.

@rdeltour rdeltour self-assigned this Mar 9, 2021
@rdeltour rdeltour added status: accepted Ready to be further processed type: false-negative This issue is about invalid content being incorrectly accepted labels Mar 9, 2021
@rdeltour rdeltour added this to the v4.2.6 milestone Mar 9, 2021
@rdeltour rdeltour modified the milestones: v4.2.7, v5.0.0 Nov 12, 2021
@rdeltour rdeltour modified the milestones: v5.0.0, v5.0.0-beta Apr 1, 2022
@rdeltour rdeltour added status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed labels Sep 30, 2022
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in progress The issue is being implemented by the development team labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: completed Work completed, can be closed type: false-negative This issue is about invalid content being incorrectly accepted
Projects
None yet
Development

No branches or pull requests

2 participants