Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI epubcheck checking more than one file at a time #1229

Open
shlomif opened this issue Mar 20, 2021 · 3 comments
Open

CLI epubcheck checking more than one file at a time #1229

shlomif opened this issue Mar 20, 2021 · 3 comments
Assignees
Labels
priority: low To be processed when time allows status: in discussion The issue is being discussed by the development team type: improvement The issue suggests an improvement of an existing feature

Comments

@shlomif
Copy link
Contributor

shlomif commented Mar 20, 2021

In https://github.com/shlomif/epubcheck/compare/master..feature-branch--multiple-files-on-cmd-line I started implementing checking multiple filenames, e.g:

java -jar ~/Download/unpack/to-del/epubcheck/target/epubcheck.jar  $(find -name '*.epub' | sort) |& tee ~/epubcheck.txt 

I still need to document it and add automated tests, but is this feature considered desirable?

(Thanks for epubcheck, btw!)

@rdeltour
Copy link
Member

Hi @shlomif. Thanks for proposal, nice!

In fact I'll soon publish a pull request for revamping the CLI. Maybe that feature can be added there instead of on the current code… I'll comment to this thread when there's something to review, and I will also have a look at your fork in the meantime!

@rdeltour rdeltour self-assigned this Mar 29, 2021
@rdeltour rdeltour added priority: low To be processed when time allows status: in discussion The issue is being discussed by the development team type: improvement The issue suggests an improvement of an existing feature labels Mar 29, 2021
@shlomif
Copy link
Contributor Author

shlomif commented Mar 30, 2021

Hi @rdeltour !

Hi @shlomif. Thanks for proposal, nice!

I'm glad you approve.

In fact I'll soon publish a pull request for revamping the CLI. Maybe that feature can be added there instead of on the current code… I'll comment to this thread when there's something to review, and I will also have a look at your fork in the meantime!

Thanks! The implementation there is still quite hacky AFAIR, and one should also add tests. Note that dealing with java/maven/jdk on epubcheck was fairly straightforward and epubcheck helped modernise and correct rebookmaker ( https://pypi.org/project/rebookmaker/ ). Great job!

@shlomif
Copy link
Contributor Author

shlomif commented Oct 24, 2021

@rdeltour : hi! was the pull-req published? can you give a link?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low To be processed when time allows status: in discussion The issue is being discussed by the development team type: improvement The issue suggests an improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants