Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running in exp mode, filenames have an .epub extension added to them #1253

Open
acabal opened this issue May 28, 2021 · 1 comment
Open
Assignees
Labels
priority: low To be processed when time allows status: accepted Ready to be further processed type: improvement The issue suggests an improvement of an existing feature

Comments

@acabal
Copy link

acabal commented May 28, 2021

Consider the following:

mkdir /tmp/test_epub
java -jar epubcheck_path -mode exp /tmp/test_epub

Output:

No mimetype file found in expanded publication, output archive will be invalid
ERROR(PKG-003): ./test_epub.epub(-1,-1): Unable to read EPUB file header. This is likely a corrupted EPUB file.
FATAL(RSC-002): ./test_epub.epub(-1,-1): Required META-INF/container.xml resource could not be found.
ERROR(RSC-001): ./test_epub.epub(-1,-1): File "META-INF/container.xml" could not be found.

Check finished with errors
Messages: 1 fatal / 2 errors / 0 warnings / 0 infos

EPUBCheck completed

Notice how the files in the output are listed as ./test_epub.epub, i.e., epubcheck has added .epub to the directory name. This occurs with all errors epubcheck outputs.

This is incorrect; the directory does not have the .epub extension. Programs parsing the output will have to know to remove the extension to get the actual file path.

@rdeltour rdeltour self-assigned this May 28, 2021
@rdeltour rdeltour added priority: low To be processed when time allows status: accepted Ready to be further processed type: improvement The issue suggests an improvement of an existing feature labels May 28, 2021
@rdeltour rdeltour added this to the v5.0.0 milestone Nov 12, 2021
@rdeltour rdeltour modified the milestones: v5.0.0, v5.0.0-rc Dec 8, 2022
@rdeltour
Copy link
Member

Good suggestion 👍. But I'm postponing this to when we rework the messaging facility, in a later version.

@rdeltour rdeltour removed this from the v5.0.0-rc milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low To be processed when time allows status: accepted Ready to be further processed type: improvement The issue suggests an improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants