Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declaring prefixes for default vocabs is an error #1306

Closed
mattgarrish opened this issue Mar 7, 2022 · 0 comments
Closed

Declaring prefixes for default vocabs is an error #1306

mattgarrish opened this issue Mar 7, 2022 · 0 comments
Assignees
@rdeltour
Labels
status: completed Work completed, can be closed type: false-negative This issue is about invalid content being incorrectly accepted
Milestone
v5.0.0-beta

Comments

@mattgarrish
Copy link
Member

I noticed this test in package-document.feature refers to issue #522 for making it a warning:

  Scenario: default vocabularies must not be assigned a prefix
  	Note: This should be an error, but is currently reported as a warning
  	See issue 522: https://github.com/w3c/epubcheck/issues/522
    When checking file 'property-prefix-declaration-default-vocabs-error.opf'

Issue 522 is about reserved prefixes, not reserved vocabulary URLs. You may declare reserved prefixes, but that's separate from trying to assign a prefix to a default vocabulary URL.

So the note is right that it should be an error. No reason I can find why not.
@rdeltour rdeltour self-assigned this Mar 8, 2022
@rdeltour rdeltour added status: accepted Ready to be further processed type: false-negative This issue is about invalid content being incorrectly accepted labels Mar 8, 2022
@rdeltour rdeltour added this to the v5.0.0 milestone Mar 8, 2022
@rdeltour rdeltour modified the milestones: v5.0.0, v5.0.0-beta Apr 1, 2022
@rdeltour rdeltour added status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed labels Nov 17, 2022
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in progress The issue is being implemented by the development team labels Dec 1, 2022
@rdeltour rdeltour mentioned this issue Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
status: completed Work completed, can be closed type: false-negative This issue is about invalid content being incorrectly accepted
Projects
None yet
Milestone
v5.0.0-beta
Development

No branches or pull requests
2 participants
@rdeltour @mattgarrish